Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info on IS_SELF_HOSTED in docs #2515

Merged
merged 2 commits into from
Jun 27, 2022
Merged

add info on IS_SELF_HOSTED in docs #2515

merged 2 commits into from
Jun 27, 2022

Conversation

arthurwolf
Copy link
Contributor

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@arthurwolf arthurwolf temporarily deployed to cachix June 26, 2022 12:44 Inactive
@arthurwolf
Copy link
Contributor Author

Screenshot:
Screenshot from 2022-06-26 14-51-13

@arthurwolf arthurwolf temporarily deployed to cachix June 26, 2022 12:53 Inactive
@arthurwolf
Copy link
Contributor Author

asked to merge by @julialongtin

@arthurwolf arthurwolf merged commit 8230d52 into develop Jun 27, 2022
@arthurwolf arthurwolf deleted the docs/is-self-hosted branch June 27, 2022 10:57
@fisx
Copy link
Contributor

fisx commented Jun 27, 2022

isn't self-hosted the default, so on-prem admins don't really need to do anything?

if not: why on earth wouldn't it be?

@arthurwolf
Copy link
Contributor Author

isn't self-hosted the default, so on-prem admins don't really need to do anything?
if not: why on earth wouldn't it be?

I checked the wire-team-setting repo, and the answer is: no default is set for the setting, so if it's not defined, it becomes undefined (in js/ts), which then will evaluate as false.

Screenshot from 2022-06-27 13-42-50

@arthurwolf
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants