Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end2end test getting remote conversation and complete its implementation #1585

Merged
merged 9 commits into from
Jun 15, 2021

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Jun 9, 2021

  • fixes the implementation of getting a conversation by ID: the conversationView and getConversationRPC call was incomplete / wrong.
  • also fixes one futurework in one brig integration test

This should have been part of #1566

@jschaul jschaul requested a review from pcapriotti June 9, 2021 22:37
@jschaul jschaul force-pushed the add-end2end-test branch from 7f95951 to 27c44b7 Compare June 9, 2021 23:47
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jschaul jschaul force-pushed the add-end2end-test branch from 7122ff1 to 35a8bf6 Compare June 10, 2021 23:08
@jschaul jschaul changed the title extend end2end federation tests to also test getting remote conversation end2end test getting remote conversation and complete its implementation Jun 14, 2021
@jschaul jschaul force-pushed the add-end2end-test branch from 9d512e1 to 8cf5f12 Compare June 15, 2021 10:29
@jschaul jschaul merged commit 41a7cb8 into develop Jun 15, 2021
@jschaul jschaul deleted the add-end2end-test branch June 15, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants