Add remote users when creating a conversation #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It allows to access a Galley instance in a monad implementing the class.
- Checks if remote users exist - Adds remote users to the database - Adds integration tests for qualified users - Updates golden tests related to NewConv
mdimjasevic
force-pushed
the
mdimjasevic/fed-new-conv-adt-and-tests
branch
from
132e453
to
176bfc3
Compare
pcapriotti
reviewed
Jun 3, 2021
Hm, I thought there is a test that does that. Initially I changed that test, but then someone (Joe?) told me it should still parse even when the new field is not given in JSON, so I reverted the change and the test still passed, i.e., it should be backwards compatible. At any rate, if you think such a test case is missing, feel free to add it. |
This is to make sure the `qualified_users` is indeed optional in the JSON being parsed.
pcapriotti
approved these changes
Jun 3, 2021
…w-conv-adt-and-tests
mdimjasevic
commented
Jun 3, 2021
Comment on lines
+34
to
+36
| testCase "NewConv" $ | ||
| testFromJSONObjects | ||
| [(testObject_NewConvUnmanaged_user_1, "testObject_NewConvUnmanaged_user_1.json")] |
There was a problem hiding this comment.
Thank you for this!
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds remote users when creating a conversation. Note: several checks are still missing, as noted in a related funuction
addMembers:-- that call should probably be made after inserting the conversation membership happens in this backend.
This PR supersedes PR #1528.