Refactoring-friendly FutureWork data type #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatting
approved these changes
May 30, 2021
| -- Example: | ||
| -- >>> let (FutureWork @'LegalholdPlusFederationNotImplemented -> _remoteUsers, localUsers) | ||
| -- >>> = partitionRemoteOrLocalIds domain qualifiedUids | ||
| newtype FutureWork label payload = FutureWork payload |
There was a problem hiding this comment.
If you plan to use the payload then uwrapping the newtype is a bit noisy
let FutureWork x' = FutureWork @'FeatNotImplemented xIf you also provide an unwrapper FutureWork -> payload and combine wrapper and unwrapper for convenience, this degenerates to
let futurework :: forall a b. b -> b
futurework = id
let x = futurework @'FeatNotImplemented (42 :: Int)
Having FutureWork type however has the advantage that you can pass futurework-values to functions in a typesafe way, so I favor the version with the type.
| @@ -1000,7 +1001,7 @@ withValidOtrRecipients protectee clt cnv rcps val now go = do | |||
| Data.deleteConversation cnv | |||
| throwM convNotFound | |||
| -- FUTUREWORK(federation): also handle remote members | |||
| localMembers <- Data.members cnv | |||
| (FutureWork @'LegalholdPlusFederationNotImplemented -> _remoteMembers, localMembers) <- (undefined,) <$> Data.members cnv | |||
There was a problem hiding this comment.
Does this have to be undefined?
There was a problem hiding this comment.
Do you prefer ()? I think I prefer undefined because it makes sure this makes it more clear it shouldn't be used anywhere. Perhaps there is a better idiom yet to be found though; I tried something diferent here
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal change, no need to show in the release notes. it's pretty small and self-explanatory.