expose /conversations/{cnv}/members/v2 for federation backends #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds explicitly configured to allow federation
|
Dear reviewer, if you agree with this PR, please merge it. |
pcapriotti
reviewed
Jun 1, 2021
There was a problem hiding this comment.
I don't understand what the point of this change is. Why should we conflate the two errors "federation-not-enabled" and "federation-not-available"? Is there any reason why we can't fix the staging/production environment by either disabling the federator endpoint completely, or by deploying a federator?
… comments to keep three booleans in sync as we have not better way here right now
pcapriotti
approved these changes
Jun 1, 2021
| const 500 === statusCode | ||
| -- FUTUREWORK: this should be a federation-not-available | ||
| -- but the error is hidden inside a server-error, confusingly. | ||
| -- separate task see cryptpad |
There was a problem hiding this comment.
Maybe not refer to internal documents in public facing code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For (test, non-production) backends explicitly configured to use federation, expose /conversations/{cnv}/members/v2 to clients. Note that the implementation of using this endpoint isn't complete yet, but it can nonetheless be tried out by clients.
This PR adds tests to ensure this endpoint cannot be called with remote users on environments that do not support federation.