Update conversation membership #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
pcapriotti/update-conversation-memberships
branch
2 times, most recently
from
ec9092e
to
e7eac8a
Compare
jschaul
approved these changes
May 31, 2021
pcapriotti
force-pushed
the
pcapriotti/update-conversation-memberships
branch
2 times, most recently
from
2376001
to
574f339
Compare
The event generated by adding users to a remote conversation should be sent to all local users in the conversation, regardless of whether any local users were added, and it should contain all users added, not just the local ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the federation RPC
update-conversation-membershipin galley. It simply registers local users as belonging to the given remote conversation and sends out an event. Actually calling this RPC from the other domain will be implemented separately in another PR.Note that at this point the event type does not properly reflect the fact that the conversation and the joined users may belong to different domains. This will be fixed once #1547 is merged.