Servantify JSON endpoint to send messages #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming this will not break the way integration tests call this end-point? |
|
I'd be surprised if we have integration tests verifying the time of the mismatch :) |
I'm talking about new tests. In a neighbor PR, we use the old end-point in tests, and hope that the new one and the helper functions in the integration tests will work the same way. (It would be nice to have integration tests use servant-client, but it would make rebasing or merging very painful in this case.) |
|
Nothing should be changed in terms of the API interface, so I don't see why integration tests would be affected. |
akshaymankar
force-pushed
the
akshaymankar/fed-prop-message
branch
from
c64fff9
to
ee25420
Compare
akshaymankar
changed the title
The tests are not enough, they don't test lists being sent to ignore_missing and report_missing
akshaymankar
force-pushed
the
akshaymankar/fed-prop-message
branch
from
ee25420
to
480340f
Compare
Also add comments and rename tests to reflect what they are testing.
akshaymankar
force-pushed
the
akshaymankar/fed-prop-message
branch
from
9644c0e
to
dd463b7
Compare
Also remove description from the schema, it is meant as a description of the response and not of the body of the response.
It is referred by status or code depending on context
akshaymankar
changed the title
jschaul
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains couple of commits from #1531 which need to be removed when that is merged