chore: remove unused files - WPB-8605 #2502
Open
+425
−4,548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbe
commented
Feb 10, 2025
| @@ -60,7 +60,6 @@ extern NSInteger const ZMTransportRequestSchedulerRequestCountUnlimited; | |||
| /// The task given access to the NSHTTPURLResponse and NSError. | |||
| - (void)processCompletedURLTask:(NSURLSessionTask *)task; | |||
| - (void)processCompletedURLResponse:(nullable NSHTTPURLResponse *)response URLError:(nullable NSError *)error; | |||
| - (void)processWebSocketError:(NSError *)error; | |||
There was a problem hiding this comment.
this is the new code removed. unused
johnxnguyen
approved these changes
Feb 10, 2025
Test Results 4 files 4 suites 7m 24s ⏱️ For more details on these failures, see this check. Results for commit a92dd06. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 4132 Passed, 2 Skipped, 5m 9.22s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In #2496, because some tests in WireTransport were failing, the cleanup was reverted.
This PR reintroduces the work done in #2221.
In addition it removes unneeded files (which were causing the tests to fail) about the WebSocket implementation. Current (legacy) code using Starscream library for websocket.
Testing
CI Tests should pass.
Checklist
[WPB-XXX].