Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux builds with electron-builder #92

Merged
merged 2 commits into from
Oct 19, 2016
Merged

Linux builds with electron-builder #92

merged 2 commits into from
Oct 19, 2016

Conversation

lipis
Copy link
Contributor

@lipis lipis commented Oct 17, 2016

@ConorIA
Copy link
Contributor

ConorIA commented Oct 17, 2016

Please make sure to include updated build instructions in the README!

@@ -10,16 +10,27 @@
"localhost": "electron electron --debug=5858 --devtools --enable-logging --env=http://localhost:8888",
"test": "eslint electron && electron-mocha tests",
"rebuild-native-modules": "electron-rebuild -m ./electron/node_modules -f",
"deb64": "electron-installer-debian --src wrap/build/Wire-linux-x64/ --arch amd64 --config linux.json",
"deb32": "electron-installer-debian --src wrap/build/Wire-linux-ia32/ --arch x32 --config linux.json"
"linux32": "build --ia32",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add -l, otherwise if you run it on macOS, it will be macOS, not Linux :)

@lipis
Copy link
Contributor Author

lipis commented Oct 17, 2016

Will do once everything is OK and final.. for some reason the --ia32 is not working.. but will continue tomorrow :)

@develar
Copy link

develar commented Oct 17, 2016

for some reason the --ia32 is not working

Hmm... What do you mean? Please specify error message. Please see To build app in 32 bit from a machine with 64 bit (not sure that it is relevant without error message).

@lipis
Copy link
Contributor Author

lipis commented Oct 17, 2016

@develar I have to admit that I was a bit lazy to check it deeper :)

@lipis
Copy link
Contributor Author

lipis commented Oct 17, 2016

screen shot 2016-10-17 at 19 09 24

Is that normal?! The 64bit shows the correct icon but not the 32bit version..

@develar
Copy link

develar commented Oct 18, 2016

@lipis I check in the evening (CET).

@lipis
Copy link
Contributor Author

lipis commented Oct 19, 2016

Did anyone have the chance to try any of these builds?! We most likely going to make a release soon and fix issues later if anything.. my only question ATM is regarding the icon of the AppImage :)

@ConorIA
Copy link
Contributor

ConorIA commented Oct 19, 2016

I ran the 64-bit AppImage. No problems, other than the preferences menu. It was neat!

@lipis lipis merged commit 2bdf509 into master Oct 19, 2016
@lipis lipis deleted the electron-builder branch October 19, 2016 14:51
@ConorIA
Copy link
Contributor

ConorIA commented Oct 19, 2016

🎉🎉🎉🎉🎉

@lipis
Copy link
Contributor Author

lipis commented Oct 19, 2016

https://wire.com/download/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants