fix: Crash on inserting mention #WPB-15717 #3856
Conversation
borichellow
requested review from
MohamadJaara,
Garzas,
ohassine and
saleniuk
borichellow
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3856 +/- ##
===========================================
+ Coverage 45.23% 45.46% +0.22%
===========================================
Files 491 491
Lines 17006 17008 +2
Branches 2845 2846 +1
===========================================
+ Hits 7693 7732 +39
+ Misses 8529 8489 -40
- Partials 784 787 +3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -200,6 +201,10 @@ class MessageCompositionHolder( | |||
| userId = UserId(contact.id, contact.domain), | |||
| handler = String.MENTION_SYMBOL + contact.name | |||
| ) | |||
| if (mention.start < 0 || mention.length < 2) { | |||
There was a problem hiding this comment.
Suggestion: Perhaps we can add tests for this case, I see we have a few on MessageCompositionHolderTest :D
|
|
Built wire-android-staging-compat-pr-3856.apk is available for download |
|
Built wire-android-dev-debug-pr-3856.apk is available for download |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
What's new in this PR?
Issues
Crash in PlayStore while inserting mention.
Causes (Optional)
Hard to understand exact STR, but the crash happens when mentions place in text can't be found. In that case mention's position is
-1and crash come up inString.subSequence(0, -1)Solutions
Added checking if mention position and length are good, do not add mention otherwise and added logs.