fix: In call video flickering on opening emojy drawer #WPB-15549 #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
sbakhtiarov,
yamilmedina,
Garzas and
saleniuk
echoes-hq
bot
added
the
echoes: product-roadmap/feature
|
|
Built wire-android-staging-compat-pr-3853.apk is available for download |
|
Built wire-android-dev-debug-pr-3853.apk is available for download |
yamilmedina
approved these changes
Feb 3, 2025
saleniuk
approved these changes
Feb 3, 2025
borichellow
deleted the
fix/in_call_video_flickering_on_openning_emojy_drawer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When the user wants to send an incall reaction and opens the emoji drawer, other participants videos are flickering.
Causes (Optional)
InCallReactionsPanel opens by
AnimatedContentAND the heigh available for participant tiles changes on every frame of that animation which causes recomposition of tiles on every frame.Solutions
Remove the opening/closing animation for the InCallReactionsPanel (recomposition has it's own animation anyway). In that case video flickering will happen only once.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
Before
document_5253870894324934517.mp4
After
document_5253870894324934518.mp4