-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash after sending a message with mentions (WPB-14797) #3706
Open
ohassine
wants to merge
2
commits into
develop
Choose a base branch
from
clear-mentions-list-after-sending-a-message
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
label
Dec 4, 2024
Built wire-android-staging-compat-pr-3706.apk is available for download |
Built wire-android-dev-debug-pr-3706.apk is available for download |
ohassine
requested review from
a team,
m-zagorski,
yamilmedina,
MohamadJaara,
vitorhugods and
damian-kaczmarek
and removed request for
a team
December 5, 2024 09:32
vitorhugods
changed the title
chore: clear mentions list after sending a messages (WPB-14797)
fix: crash after sending a message with mentions (WPB-14797)
Dec 5, 2024
vitorhugods
approved these changes
Dec 5, 2024
yamilmedina
approved these changes
Dec 5, 2024
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3706.apk is available for download |
Built wire-android-dev-debug-pr-3706.apk is available for download |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
After sending a message, the list of mentions is not cleared which will cause a crash if the user starts typing again.
Causes (Optional)
This is because we are applying mention style on text input based on mentions list. Keeping old mentions will result to use wrong positions, which will throw
OutOfBoundException
👯♂️Solutions
Clear mention list after sending a message
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.