-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash after sending a message with mentions (WPB-14797) #3706
fix: crash after sending a message with mentions (WPB-14797) #3706
Conversation
Built wire-android-staging-compat-pr-3706.apk is available for download |
Built wire-android-dev-debug-pr-3706.apk is available for download |
Built wire-android-staging-compat-pr-3706.apk is available for download |
Built wire-android-dev-debug-pr-3706.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3706.apk is available for download |
Built wire-android-dev-debug-pr-3706.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
After sending a message, the list of mentions is not cleared which will cause a crash if the user starts typing again.
Causes (Optional)
This is because we are applying mention style on text input based on mentions list. Keeping old mentions will result to use wrong positions, which will throw
OutOfBoundException
👯♂️Solutions
Clear mention list after sending a message
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.