Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong error message background color [WPB-11475] #3703

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 3, 2024

StoryWPB-11475 Resolve custom colors in Android color scheme


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

After resolving custom colors, one was mapped wrongly, so in this PR errorVariant is changed to proper LightRed50.

Testing

How to Test

Try to send a message without internet on light theme and check the message background color.

Attachments (Optional)

Before After

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 3, 2024
@saleniuk saleniuk requested review from a team, yamilmedina, MohamadJaara, vitorhugods, Garzas and mathias-niboulies and removed request for a team December 3, 2024 13:31
Copy link

sonarcloud bot commented Dec 3, 2024

@ohassine ohassine added this pull request to the merge queue Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Built wire-android-staging-compat-pr-3703.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Built wire-android-dev-debug-pr-3703.apk is available for download

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2024
@saleniuk saleniuk added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit de21d20 Dec 3, 2024
13 of 14 checks passed
@saleniuk saleniuk deleted the fix/error-message-background-color branch December 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants