fix: revert of #3670 (WPB-14433) 🍒 #3702
Open
+680
−511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
saleniuk
reviewed
Dec 3, 2024
Comment on lines
-77
to
-82
| // limit the scope of the ViewModel to the current activity so that there's one image loader instance for the Activity | ||
| viewModelStoreOwner = checkNotNull(LocalActivity.current as? AppCompatActivity ?: LocalViewModelStoreOwner.current) { | ||
| "No ViewModelStoreOwner was provided via LocalViewModelStoreOwner" | ||
| }, | ||
| key = "remote_asset_image_loader" | ||
| ).imageLoader.paint(asset = this, fallbackData = fallbackData, withCrossfadeAnimation = withCrossfadeAnimation) |
There was a problem hiding this comment.
I'm not sure but now after understanding the issues with images I think that this could be the problem, so just removing passing viewmodelStoreOwner and a key should make it so that this view model and image loader is created per particular screen and not whole activity which means it's created again when account is switched 🙇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We introduced by caching the images, a problem visible as well by federation being enabled this week.
Causes (Optional)
Image loader is cached, and tries to use federation for assets.
Solutions
Revert the PR #3670 and pick the fixes needed only (#3689)
Testing
Test Coverage (Optional)
How to Test
Login with 2 accounts in different backends (staging and prod) and you should NOT have failed to load images.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.