Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable paginated conversation list [WPB-14657] #3681

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 28, 2024

StoryWPB-14657 [Android] enable paginated conversation list


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

enable paginated conversation list

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Built wire-android-staging-compat-pr-3681.apk is available for download

@MohamadJaara MohamadJaara changed the title chore: enable paginated conversation list chore: enable paginated conversation list [WPB-14657] Dec 2, 2024
@MohamadJaara MohamadJaara merged commit 368d4f5 into release/candidate Dec 2, 2024
3 checks passed
@MohamadJaara MohamadJaara deleted the chore/enable-pagination-on-prod branch December 2, 2024 13:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.94%. Comparing base (8f3242f) to head (e527fd1).
Report is 231 commits behind head on release/candidate.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3681      +/-   ##
=====================================================
+ Coverage              44.70%   44.94%   +0.24%     
=====================================================
  Files                    456      471      +15     
  Lines                  15466    15725     +259     
  Branches                2586     2686     +100     
=====================================================
+ Hits                    6914     7068     +154     
- Misses                  7822     7901      +79     
- Partials                 730      756      +26     

see 115 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e91d46...e527fd1. Read the comment docs.

Copy link

sonarcloud bot commented Dec 2, 2024

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Built wire-android-staging-compat-pr-3681.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants