Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more errors handling for personal migration #WPB-14281 #3674

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Nov 27, 2024

TaskWPB-14281 [Android] Handle error cases in case the migration failed

What's new in this PR?

Issues

  • add more error handling types and corresponding dialogs

Needs releases with:

Testing

How to Test

  • comment if in SelfUserProfileScreen.237 if (state.teamName == null) {
  • login to account with team
  • go through the migration process from you profile screen
  • you will get error dialog
  • you can change dialogs by editing MigrateFromPersonalToTeamUseCaseImpl:63 and return different errors

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Built wire-android-staging-compat-pr-3674.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3674.apk is available for download

@damian-kaczmarek damian-kaczmarek marked this pull request as ready for review November 27, 2024 16:00
@damian-kaczmarek damian-kaczmarek requested review from Garzas, ohassine, a team, yamilmedina, alexandreferris and vitorhugods and removed request for a team November 27, 2024 16:00
…personal-team-errors-android

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationViewModel.kt
#	kalium
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.76%. Comparing base (aa35a0b) to head (59c9417).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3674   +/-   ##
========================================
  Coverage    45.76%   45.76%           
========================================
  Files          472      472           
  Lines        16027    16027           
  Branches      2709     2709           
========================================
  Hits          7335     7335           
  Misses        7929     7929           
  Partials       763      763           
Files with missing lines Coverage Δ
...ui/userprofile/teammigration/TeamMigrationState.kt 100.00% <100.00%> (ø)
...serprofile/teammigration/TeamMigrationViewModel.kt 94.73% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa35a0b...59c9417. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3674.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3674.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3674.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3674.apk is available for download

Copy link

sonarcloud bot commented Nov 29, 2024

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Nov 29, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3674.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3674.apk is available for download

Merged via the queue into develop with commit 736d665 Nov 29, 2024
12 of 13 checks passed
@damian-kaczmarek damian-kaczmarek deleted the feat/personal-team-errors-android branch November 29, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants