fix: resolve custom colors [WPB-11475] #3656
Conversation
echoes-hq
bot
added
the
echoes: product-roadmap
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
| @@ -115,6 +115,10 @@ android { | |||
| getByName("androidTest") { | |||
| java.srcDirs("src/androidTest/kotlin") | |||
| } | |||
| create("screenshotTest") { | |||
There was a problem hiding this comment.
It's to make message previews to be properly rendered in Android Studio, as they are now moved to screenshotTest.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3656 +/- ##
========================================
Coverage 46.08% 46.08%
========================================
Files 473 472 -1
Lines 16150 16149 -1
Branches 2675 2675
========================================
Hits 7443 7443
+ Misses 7929 7928 -1
Partials 778 778
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3656.apk is available for download |
|
Built wire-android-dev-debug-pr-3656.apk is available for download |
saleniuk
requested review from
Garzas,
a team,
typfel,
alexandreferris,
MohamadJaara and
ohassine
and removed request for
a team
…esolve-custom-colors # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/details/GroupConversationDetailsScreen.kt # app/src/main/kotlin/com/wire/android/ui/userprofile/self/CreateTeamInfoCard.kt
|
Built wire-android-staging-compat-pr-3656.apk is available for download |
|
Built wire-android-dev-debug-pr-3656.apk is available for download |
…esolve-custom-colors
|
|
Built wire-android-staging-compat-pr-3656.apk is available for download |
|
Built wire-android-dev-debug-pr-3656.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We have a lot of custom colors that are not included in the design documentation.
Solutions
Removed all unneeded custom colors from our color scheme and replaced them with the ones that are included in the design documentation.
Added "surface container" colors, they are not yet included in the designs but they are now required by the material 3 and they helped to make colors work as in designs we have too many different background colors (material3 doesn't use
backgroundVariantfor instance so it's matched by usingsurfaceContainerLowfor instance).Fixed some previews and added new ones.
Unified elements like checkboxes in the app.
Added new "fixed" color scheme for colors that are always the same no matter which mode is used, idea and suggested implementation implementation on which it was based:
https://m3.material.io/styles/color/roles#26b6a882-064d-4668-b096-c51142477850
https://developer.android.com/reference/kotlin/androidx/compose/material3/ColorScheme
For elements which always are in the same one mode, like call tiles (always dark), there are new extension functions
darkColorsSchemeandlightColorsSchemeto use only the colors from this particular mode instead of them being changed depending on currently used mode on the phone, as it's the more practical approach than duplicating the same colors in both specific mode's scheme and fixed color scheme.Testing
How to Test
Just open the app and check if the colors are right.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.