Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hide personal to team migration feature if not supported by backend (WPB-12022) #3650

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 20, 2024

TaskWPB-12022 [Android] API V7 related client ticket


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

If the backend does not support personal to team migration feature yet, we need to hide the feature

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title Hide personal to team migration feature if not supported by backend (WPB-12022) feat: Hide personal to team migration feature if not supported by backend (WPB-12022) Nov 20, 2024
…feature-if-not-supported-by-backend' into hide-personal-to-team-migration-feature-if-not-supported-by-backend
@ohassine ohassine added this pull request to the merge queue Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.11%. Comparing base (32f196e) to head (a2f9738).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 57.14% 2 Missing and 1 partial ⚠️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3650      +/-   ##
===========================================
+ Coverage    46.08%   46.11%   +0.02%     
===========================================
  Files          473      473              
  Lines        16150    16154       +4     
  Branches      2675     2675              
===========================================
+ Hits          7443     7449       +6     
+ Misses        7929     7927       -2     
  Partials       778      778              
Files with missing lines Coverage Δ
...ndroid/ui/userprofile/self/SelfUserProfileState.kt 100.00% <100.00%> (ø)
...serprofile/teammigration/TeamMigrationViewModel.kt 94.73% <ø> (-0.14%) ⬇️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 57.24% <75.00%> (+0.52%) ⬆️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 65.45% <57.14%> (+5.45%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f196e...a2f9738. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3650.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3650.apk is available for download

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@ohassine ohassine added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 28, 2024
Copy link

sonarcloud bot commented Nov 28, 2024

@ohassine ohassine added this pull request to the merge queue Nov 28, 2024
Merged via the queue into develop with commit 2e06e37 Nov 28, 2024
12 of 13 checks passed
@ohassine ohassine deleted the hide-personal-to-team-migration-feature-if-not-supported-by-backend branch November 28, 2024 13:26
Copy link
Contributor

Built wire-android-staging-compat-pr-3650.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3650.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants