Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: big padding around reaction pills #WPB-12094 #WPB-14269 #3643

Merged
merged 6 commits into from
Nov 28, 2024
Merged

fix: big padding around reaction pills #WPB-12094 #WPB-14269 #3643

merged 6 commits into from
Nov 28, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Nov 18, 2024 •
edited by github-actions bot
Loading

BugWPB-12094 [Android] Gap between reactions when they go to next line

What's new in this PR?

Issues

Too big padding around reactions. Other changes are just cutting the RegularMessageItem into more files as detekt was triggered.

Causes (Optional)

Our override of minimal size used for accessibility got deprecated .

Solutions

Replaced with minimal size unspecified.

Also replaced in one other place, although I don't think it mattered there.

Testing

Test Coverage (Optional)

This kind of UI bugs could be easy to spot in golden tests, so I added previews

How to Test

Add many different reactions to the single message to the point it wraps around the screen.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.11%. Comparing base (04c9a3d) to head (013451c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../conversations/messages/item/SwipableToReplyBox.kt 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3643   +/-   ##
========================================
  Coverage    46.11%   46.11%           
========================================
  Files          472      473    +1     
  Lines        16140    16140           
  Branches      2674     2674           
========================================
  Hits          7443     7443           
  Misses        7919     7919           
  Partials       778      778
Files with missing lines Coverage Δ
.../kotlin/com/wire/android/ui/edit/ReactionOption.kt 0.00% <ø> (ø)
...oid/ui/home/conversations/messages/ReactionPill.kt 0.00% <ø> (ø)
.../conversations/messages/item/RegularMessageItem.kt 0.00% <ø> (ø)
.../conversations/messages/item/SwipableToReplyBox.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c9a3d...013451c. Read the comment docs.

@saleniuk
Copy link
Contributor

Now I realised it's still a "draft", but my suggestions can still be helpful at this point 😅

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3643.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3643.apk is available for download

@damian-kaczmarek damian-kaczmarek mentioned this pull request Nov 19, 2024
Merged
6 tasks
@damian-kaczmarek damian-kaczmarek marked this pull request as ready for review November 19, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3643.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3643.apk is available for download

@damian-kaczmarek damian-kaczmarek requested review from yamilmedina, a team, m-zagorski, MohamadJaara and mathias-niboulies and removed request for a team November 22, 2024 15:01
@damian-kaczmarek
Merge remote-tracking branch 'refs/remotes/origin/develop' into fix/r…
58366f6 
…eaction-paddings

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/item/RegularMessageItem.kt
@github-actions GitHub Actions
Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
c7b96a2584d6cba1619501b917a90b757785b7ac d140d791a308632e568b0ee3f8685644bad90424

Is this intentional?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3643.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3643.apk is available for download

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Nov 28, 2024
Merged via the queue into develop with commit 8a60716 Nov 28, 2024
11 of 12 checks passed
@damian-kaczmarek damian-kaczmarek deleted the fix/reaction-paddings branch November 28, 2024 07:30
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@m-zagorski m-zagorski Awaiting requested review from m-zagorski m-zagorski was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@mathias-niboulies mathias-niboulies Awaiting requested review from mathias-niboulies mathias-niboulies was automatically assigned from wireapp/android

Assignees

@damian-kaczmarek damian-kaczmarek

Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damian-kaczmarek @codecov-commenter @saleniuk @yamilmedina