-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update app version name #WPB-11429 #3489
Conversation
Built wire-android-staging-compat-pr-3489.apk is available for download |
Built wire-android-dev-debug-pr-3489.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are 2 places that need to be changed updated to include the lest significant digits of the code and the build flavour
Indeed, my mistake. I've changed those places and also other ones which were using raw |
Built wire-android-staging-compat-pr-3489.apk is available for download |
Built wire-android-dev-debug-pr-3489.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3489.apk is available for download |
Built wire-android-dev-debug-pr-3489.apk is available for download |
What's new in this PR?
Update app version name to contain only the version ie 4.9.0 without version code and flavor. This will simplify fdroid integration.
Issues
There were issues with matching version name with tag for fdroid integration, thats why we're simplifying it.
Solutions
Version names generated contain only raw version name, the UI representation is build exactly as it was before so
versionName-leastSignificantVersionCode-flavor
Testing
How to Test
Open the app and check in the settings that version name is in unchanged format ie
4.9.0-32599-beta
soversionName-leastSignificantVersionCode-flavor
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.