-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: audio converting error on lower APIs [WPB-11242] #3467
Conversation
…into fix/record-audio-storage-error
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3467 +/- ##
=====================================================
- Coverage 44.73% 44.70% -0.04%
=====================================================
Files 456 456
Lines 15454 15466 +12
Branches 2584 2586 +2
=====================================================
Hits 6914 6914
- Misses 7810 7822 +12
Partials 730 730
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3467.apk is available for download |
Co-authored-by: Jakub Zerko <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
On Android 9, the app is crashing when sending a recorded audio.
Causes (Optional)
Crash due to out of order frames.
Solutions
Change the way
presentationTimeUs
is calculated, it looks like starting from some value different than 0 is error-prone, so make sure that it starts with 0. Returningsuccess
to not send faulty file if something wrong happened during the conversion.Testing
How to Test
It was crashing on device with Android 9 when clicking "send" after user finished recording audio message.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.