Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update compose-bom lib and androidx-compose-runtime (WPB-11069) #3437

Merged
merged 2 commits into from
Sep 12, 2024
Merged

chore: update compose-bom lib and androidx-compose-runtime (WPB-11069) #3437

merged 2 commits into from
Sep 12, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Sep 12, 2024 •
edited by github-actions bot
Loading

TaskWPB-11069 [Android] update compose bom lib

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

New version of compose-bom lib

Solutions

Update libraries:
compose-bom from 2024.09.00 to 2024.09.01
androidx-compose-runtime from 1.7.0 to 1.7.1

Testing

How to Test

UIs should be running as before

@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and saleniuk and removed request for a team September 12, 2024 09:35
Garzas
Garzas approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexandreferris alexandreferris added this pull request to the merge queue Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3437.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3437.apk is available for download

Merged via the queue into develop with commit cb2a0a5 Sep 12, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the chore/update_compose_bom_lib branch September 12, 2024 10:45
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreferris @yamilmedina @Garzas