Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add analytics initial events (WPB-10589) 🍒 #3436

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 12, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-10589 [Android] Implement events and segmentation as is on iOS


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Implement anonymous analytics for events contribution,

Causes (Optional)

Never implemented

Solutions

Implement the same as the other platforms were doing

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/M labels Sep 12, 2024
Copy link

sonarcloud bot commented Sep 12, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 44.76%. Comparing base (0be7bbe) to head (e8de905).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../conversations/sendmessage/SendMessageViewModel.kt 83.33% 1 Missing and 4 partials ⚠️
.../home/settings/backup/BackupAndRestoreViewModel.kt 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3436      +/-   ##
===========================================
+ Coverage    44.67%   44.76%   +0.08%     
===========================================
  Files          465      465              
  Lines        15610    15648      +38     
  Branches      2630     2638       +8     
===========================================
+ Hits          6974     7005      +31     
- Misses        7885     7888       +3     
- Partials       751      755       +4     
Files with missing lines Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <ø> (ø)
.../home/settings/backup/BackupAndRestoreViewModel.kt 87.19% <75.00%> (-0.63%) ⬇️
.../conversations/sendmessage/SendMessageViewModel.kt 83.98% <83.33%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be7bbe...e8de905. Read the comment docs.

@alexandreferris alexandreferris requested review from a team, yamilmedina, vitorhugods, mchenani, Garzas and ohassine and removed request for a team September 12, 2024 08:09
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3436.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3436.apk is available for download

@alexandreferris alexandreferris added this pull request to the merge queue Sep 12, 2024
Merged via the queue into develop with commit 458be14 Sep 12, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the feat/add_analytics_initial_events-cherry-pick branch September 12, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants