Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sending GIFs from keyboard [WPB-1715] #3416

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Sep 4, 2024

StoryWPB-1715 Support Sending GIFs


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • implemented support of sending GIFs using third-party keyboards that support GIF functionality (e.g., Gboard, SwiftKey)
  • updated image preview screen to match designs when single image is being shown
  • removed resampling when GIF has too large dimensions as it changes GIF into PNG or JPEG - static image instead of GIF

Testing

How to Test

You need to use one of the keyboards that support GIF functionality (e.g. Gboard, SwiftKey).
Open conversation, click on text input, open GIF selector and choose one GIF - image preview screen with this GIF should be opened and you should be able to send this gif (if the size of this GIF file is not too big, of course).

Attachments (Optional)

Before After
gif_keyboard_before.mp4
gif_keyboard_after.mp4
large_dimensions_gif_before.mp4
large_dimensions_gif_after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Sep 4, 2024
Copy link

sonarcloud bot commented Sep 4, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 44.48%. Comparing base (9007e80) to head (17f7bcc).

Files with missing lines Patch % Lines
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% 14 Missing ⚠️
...ersations/media/CheckAssetRestrictionsViewModel.kt 0.00% 1 Missing ⚠️
...src/main/kotlin/com/wire/android/util/ImageUtil.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3416   +/-   ##
========================================
  Coverage    44.48%   44.48%           
========================================
  Files          464      464           
  Lines        15554    15554           
  Branches      2602     2604    +2     
========================================
  Hits          6919     6919           
  Misses        7899     7899           
  Partials       736      736           
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
...ersations/media/CheckAssetRestrictionsViewModel.kt 0.00% <0.00%> (ø)
...src/main/kotlin/com/wire/android/util/ImageUtil.kt 1.81% <0.00%> (-0.04%) ⬇️
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 5.85% <0.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9007e80...17f7bcc. Read the comment docs.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Built wire-android-staging-compat-pr-3416.apk is available for download

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Built wire-android-dev-debug-pr-3416.apk is available for download

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and ohassine and removed request for a team September 5, 2024 07:12
@saleniuk saleniuk added this pull request to the merge queue Sep 5, 2024
Merged via the queue into develop with commit 8d49aff Sep 5, 2024
11 of 12 checks passed
@saleniuk saleniuk deleted the feat/sending-gif-from-keyboard branch September 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants