-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Display ErrorCode for DecryptionError [WPB-1795] #3414
feat: Display ErrorCode for DecryptionError [WPB-1795] #3414
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3414 +/- ##
===========================================
- Coverage 44.68% 44.67% -0.01%
===========================================
Files 465 465
Lines 15602 15609 +7
Branches 2627 2629 +2
===========================================
+ Hits 6971 6974 +3
- Misses 7880 7884 +4
Partials 751 751
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3414.apk is available for download |
Built wire-android-dev-debug-pr-3414.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3414.apk is available for download |
Built wire-android-dev-debug-pr-3414.apk is available for download |
What's new in this PR?
Issues
We want to inform user what is the exact error code which caused Decryption error.
Solutions
Update kalium to store that code and display it in UI
Also added "Break the session" button in device details screen (for debug builds) so it would be easier to test such a scenarios.
Dependencies (Optional)
Waiting for kalium PR be merged wireapp/kalium#2989
Attachments (Optional)