Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display ErrorCode for DecryptionError [WPB-1795] #3414

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Sep 3, 2024

StoryWPB-1795 Display Decryption error message according to Design


What's new in this PR?

Issues

We want to inform user what is the exact error code which caused Decryption error.

Solutions

Update kalium to store that code and display it in UI
Also added "Break the session" button in device details screen (for debug builds) so it would be easier to test such a scenarios.

Dependencies (Optional)

Waiting for kalium PR be merged wireapp/kalium#2989

Attachments (Optional)

Screenshot 2024-09-03 at 16 41 56 Screenshot 2024-09-03 at 16 42 08

@borichellow borichellow self-assigned this Sep 3, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Sep 3, 2024
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.67%. Comparing base (681a19c) to head (38aa853).

Files with missing lines Patch % Lines
...wire/android/mapper/RegularMessageContentMapper.kt 0.00% 4 Missing ⚠️
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3414      +/-   ##
===========================================
- Coverage    44.68%   44.67%   -0.01%     
===========================================
  Files          465      465              
  Lines        15602    15609       +7     
  Branches      2627     2629       +2     
===========================================
+ Hits          6971     6974       +3     
- Misses        7880     7884       +4     
  Partials       751      751              
Files with missing lines Coverage Δ
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 61.16% <100.00%> (ø)
...nversations/messages/item/MessageItemComponents.kt 0.00% <ø> (ø)
...conversations/messages/item/MessageTypesPreview.kt 0.00% <ø> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 52.01% <100.00%> (+0.27%) ⬆️
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 67.52% <50.00%> (-0.31%) ⬇️
...wire/android/mapper/RegularMessageContentMapper.kt 19.60% <0.00%> (-0.40%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681a19c...38aa853. Read the comment docs.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Built wire-android-staging-compat-pr-3414.apk is available for download

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Built wire-android-dev-debug-pr-3414.apk is available for download

Copy link

sonarcloud bot commented Sep 11, 2024

@borichellow borichellow added this pull request to the merge queue Sep 11, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3414.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3414.apk is available for download

Merged via the queue into develop with commit b6df664 Sep 11, 2024
12 of 13 checks passed
@borichellow borichellow deleted the feat/display_error_code_for_decryption_error branch September 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants