Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an intent for importing external events (WPB-10756) #3384

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

typfel
Copy link
Member

@typfel typfel commented Aug 27, 2024

TaskWPB-10756 [Clients] Build tooling for generating random events for performance testing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add an intent for importing external events from a file

Needs releases with:

Testing

How to Test

Launch the Wire app in debug mode and run the following adb commands:

> adb root
> adb push /path/to/events.txt "/data/data/com.wire.android.internal.debug/files"
> adb shell am start -W -a android.intent.action.SYNC -d file:///events.txt

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Aug 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 44.48%. Comparing base (98be6a7) to head (773e803).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...otlin/com/wire/android/ui/WireActivityViewModel.kt 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3384      +/-   ##
===========================================
- Coverage    44.51%   44.48%   -0.04%     
===========================================
  Files          465      465              
  Lines        15582    15594      +12     
  Branches      2616     2621       +5     
===========================================
  Hits          6937     6937              
- Misses        7903     7915      +12     
  Partials       742      742              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 69.66% <0.00%> (-2.91%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98be6a7...773e803. Read the comment docs.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Built wire-android-staging-compat-pr-3384.apk is available for download

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Built wire-android-dev-debug-pr-3384.apk is available for download

Copy link

sonarcloud bot commented Sep 6, 2024

@typfel typfel added this pull request to the merge queue Sep 6, 2024
Merged via the queue into develop with commit e9adb43 Sep 6, 2024
12 of 13 checks passed
@typfel typfel deleted the feat/import-external-events branch September 6, 2024 11:59
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Built wire-android-staging-compat-pr-3384.apk is available for download

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Built wire-android-dev-debug-pr-3384.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants