Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing staging backend verification for analytics (WPB-10736) 🍒 #3368

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-10736 [Android] Analytics enabled shows false for users on staging, after they agreed to share data

…ifier


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was no verification for staging backend api when observing analytics toggle change

Causes (Optional)

Missed out this part

Solutions

Add staging backend api when observing analytics toggle change to propagate identifier and initialize analytics

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Aug 23, 2024
@alexandreferris alexandreferris requested review from a team, alexandreferris, MohamadJaara, mchenani, Garzas and ohassine and removed request for a team August 23, 2024 15:50
Copy link

@alexandreferris alexandreferris added this pull request to the merge queue Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (8ace2c0) to head (d542b78).
Report is 61 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3368   +/-   ##
========================================
  Coverage    44.54%   44.55%           
========================================
  Files          458      458           
  Lines        15421    15423    +2     
  Branches      2573     2575    +2     
========================================
+ Hits          6870     6872    +2     
  Misses        7826     7826           
  Partials       725      725           
Files with missing lines Coverage Δ
...analytics/ObserveCurrentSessionAnalyticsUseCase.kt 83.33% <100.00%> (+0.98%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ace2c0...d542b78. Read the comment docs.

Merged via the queue into develop with commit 6e4ec6e Aug 23, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the fix/add_missing_staging_backend_verification_for_analytics-cherry-pick branch August 23, 2024 16:26
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3368.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3368.apk is available for download

@echoes-hq echoes-hq bot added echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: throughput/ci-maintenance labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants