Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Analytics dialog (WPB-10601) 🍒 #3338

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 19, 2024

TaskWPB-10601 [Android] Make countly dialogue not dismissible

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Dialog is dismissable
  • Text copy was updated

Solutions

  • Remove the possibility to dismiss the dialog without properly selecting a action button.
  • Update text copy of dialog
  • rename variable naming (previously added staging to valid backend verification)

Dependencies (Optional)

Testing

How to Test

  • Fresh login with analytics enabled in build level
  • dialog is shown and is not dismissible

Attachments (Optional)

Dialog Toggle

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Aug 19, 2024
@alexandreferris alexandreferris requested review from a team, typfel, mchenani, Garzas, ohassine and saleniuk and removed request for a team August 19, 2024 08:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (f6561f6) to head (d8f40bf).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3338   +/-   ##
========================================
  Coverage    44.55%   44.55%           
========================================
  Files          458      458           
  Lines        15419    15419           
  Branches      2572     2572           
========================================
  Hits          6870     6870           
  Misses        7824     7824           
  Partials       725      725           
Files Coverage Δ
...re/android/ui/analytics/AnalyticsUsageViewModel.kt 93.10% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6561f6...d8f40bf. Read the comment docs.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3338.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3338.apk is available for download

Copy link

sonarcloud bot commented Aug 19, 2024

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3338.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3338.apk is available for download

@alexandreferris alexandreferris added this pull request to the merge queue Aug 19, 2024
Merged via the queue into develop with commit f6eaf4e Aug 19, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the chore/improve_analytics_dialog-cherry-pick branch August 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants