-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bottom sheet options to images and files on conversation media gallery [WPB-9049] #3337
feat: add bottom sheet options to images and files on conversation media gallery [WPB-9049] #3337
Conversation
…dia gallery [WPB-9049]
…conversation-media-gallery-bottom-sheet-options
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3337 +/- ##
===========================================
- Coverage 44.66% 44.55% -0.12%
===========================================
Files 456 458 +2
Lines 15380 15419 +39
Branches 2572 2572
===========================================
Hits 6870 6870
- Misses 7785 7824 +39
Partials 725 725
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3337.apk is available for download |
Built wire-android-dev-debug-pr-3337.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work 💪🏻
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
In order to make the implementation of these bottom sheets easier and make the code more dev-friendly, some other small adjustments were also made to the code. Here’s the full list of changes included in this PR:
messageOptionsMenuItems
to make it unified with other from this package, removed handling of closing the menu here, this is now handled directly in the bottom sheetSnackBarMessageHandler
andactionLabel
property toSnackBarMessage
so that it can be easily added and used and the whole handler can be reused in the appConversationScreen
to dedicated files:MessageOptionsModalSheetLayout
andSelfDeletionOptionsModalSheetLayout
MediaAssetImage
on previewsConversationMediaScreen
and bottom sheets on multiple screenTesting
How to Test
Open conversation media screen and long-click on any item.
Attachments (Optional)
Screen_recording_20240818_103722.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.