Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: show hide analytics toggle (WPB-10587) 🍒 #3325

Merged
merged 2 commits into from
Aug 14, 2024
Merged

chore: show hide analytics toggle (WPB-10587) 🍒 #3325

merged 2 commits into from
Aug 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 14, 2024 •
edited
Loading

StoryWPB-10587 [Android] Hide/Show Analytics Toggle in Privacy Settings Screen

This PR was automatically cherry-picked based on the following PR:

Original PR description:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Analytics Toggle was always being shown despite being disabled from build config

Causes (Optional)

Not implemented

Solutions

Verify if build config for ANALYTICS_ENABLED is enabled before showing toggle

Testing

How to Test

  • Open App
  • Login
  • Open Privacy Settings Screen
  • Check if Analytics Toggle is shown/hidden based on build config

Attachments (Optional)

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS labels Aug 14, 2024
@alexandreferris alexandreferris requested review from a team, yamilmedina, MohamadJaara, vitorhugods, mchenani and Garzas and removed request for a team August 14, 2024 08:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3325.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor Author

Built wire-android-dev-debug-pr-3325.apk is available for download

@alexandreferris alexandreferris added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit 1808cc8 Aug 14, 2024
12 checks passed
@alexandreferris alexandreferris deleted the chore/show_hide_analytics_toggle-cherry-pick branch August 14, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamilmedina @alexandreferris @MohamadJaara