Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete button appears briefly when opening account screen - cherrypick (WPB-7426) #3293

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 6, 2024

BugWPB-7426 [Android] Delete account button on account details screen

…426) (#3283)

(cherry picked from commit 59c23d9)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #3283

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 6, 2024
Copy link

sonarcloud bot commented Aug 6, 2024

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.43%. Comparing base (f1d68ba) to head (9e9cc43).

Files Patch % Lines
...oid/ui/home/settings/account/MyAccountViewModel.kt 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3293      +/-   ##
=====================================================
+ Coverage              44.40%   44.43%   +0.03%     
=====================================================
  Files                    453      453              
  Lines                  15288    15298      +10     
  Branches                2552     2552              
=====================================================
+ Hits                    6788     6798      +10     
  Misses                  7784     7784              
  Partials                 716      716              
Files Coverage Δ
...android/ui/home/settings/account/MyAccountState.kt 100.00% <100.00%> (ø)
...oid/ui/home/settings/account/MyAccountViewModel.kt 87.50% <92.30%> (+2.39%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d68ba...9e9cc43. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Built wire-android-staging-compat-pr-3293.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Built wire-android-internal-compat-pr-3293.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 6, 2024
Merged via the queue into release/candidate with commit 8d35334 Aug 6, 2024
13 checks passed
@MohamadJaara MohamadJaara deleted the fix-delete-button-appears-briefly-when-opening-account-screen-rc branch August 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants