Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connection button not shown when partial metadata (WPB-10342) #3280

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 5, 2024

BugWPB-10342 [Android] Accept connection request button is not visible for personal accounts


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There might be cases that metadata is incomplete (username or handle)

Causes (Optional)

We hide the action buttons for connection requests.

Solutions

  • Treat partial metadata as enough to connect, since we have a cache of 5 minutes, where this data will be refreshed anyway.
  • Add expiresAt mapping, so we also handle connection/role edition for temporary users.
  • Add a bunch of UI tests to verify: Role selection and Connection action buttons.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Aug 5, 2024
@yamilmedina yamilmedina requested a review from Garzas August 5, 2024 10:16
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 5, 2024
@yamilmedina yamilmedina requested review from saleniuk, a team, borichellow, MohamadJaara, mchenani and alexandreferris and removed request for a team August 5, 2024 10:16
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.57%. Comparing base (65bdbb4) to head (90f3346).

Files Patch % Lines
...roid/ui/userprofile/other/OtherUserProfileState.kt 50.00% 2 Missing ⚠️
...in/kotlin/com/wire/android/mapper/ContactMapper.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3280      +/-   ##
=====================================================
+ Coverage              44.56%   44.57%   +0.01%     
=====================================================
  Files                    453      453              
  Lines                  15188    15192       +4     
  Branches                2522     2523       +1     
=====================================================
+ Hits                    6768     6772       +4     
  Misses                  7702     7702              
  Partials                 718      718              
Files Coverage Δ
...lin/com/wire/android/mapper/UIParticipantMapper.kt 46.03% <100.00%> (+0.87%) ⬆️
...re/android/ui/connection/ConnectionActionButton.kt 0.00% <ø> (ø)
...ations/details/participants/model/UIParticipant.kt 100.00% <100.00%> (ø)
...e/android/ui/home/newconversation/model/Contact.kt 100.00% <ø> (+12.50%) ⬆️
...roid/ui/userprofile/other/OtherUserProfileGroup.kt 0.00% <ø> (ø)
...erprofile/other/OtherUserProfileScreenViewModel.kt 59.58% <100.00%> (+0.21%) ⬆️
...in/kotlin/com/wire/android/mapper/ContactMapper.kt 0.00% <0.00%> (ø)
...roid/ui/userprofile/other/OtherUserProfileState.kt 76.08% <50.00%> (-1.19%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bdbb4...90f3346. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Built wire-android-staging-compat-pr-3280.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Built wire-android-internal-compat-pr-3280.apk is available for download

@mchenani mchenani enabled auto-merge August 5, 2024 12:41
Copy link

sonarcloud bot commented Aug 5, 2024

@mchenani mchenani added this pull request to the merge queue Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Built wire-android-staging-compat-pr-3280.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Built wire-android-internal-compat-pr-3280.apk is available for download

Merged via the queue into release/candidate with commit d746711 Aug 5, 2024
11 of 12 checks passed
@mchenani mchenani deleted the fix/metadata-button branch August 5, 2024 13:32
github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants