Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call participants tiles UI [WPB-10149] #3202

Merged
merged 9 commits into from
Jul 19, 2024
Merged

fix: call participants tiles UI [WPB-10149] #3202

merged 9 commits into from
Jul 19, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jul 18, 2024 •
edited by github-actions bot
Loading

BugWPB-10149 [Android] Tiles in calling UI are cut of on last row

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

During a call with more then 8 participants, the last row of tiles is cut off.
User name can overlap the mute icon.
Some ongoing call elements don't match designs.

Solutions

  • Calculate height of tiles correctly.
  • Fix layout of user name, "connecting" label and "mute" icon to make it all be shown properly.
  • Update avatar composable to allow using it without any indications (status, legal hold) and thus to not have any unnecessary paddings. It allowed also to fix and make typing indicator to be like on designs.
  • Make corners and borders to match designs ("active speaker" border, name and mute icon corners).

Testing

How to Test

Create a call with multiple participants and check the UI.

Attachments (Optional)

These screenshots below are in high resolution, click and open to see in detail and compare.

Before After Design
tiles_before tiles_after tiles_design
call_screen_before call_screen_after call_sceen_design
typing_indicator_before typing_indicator_after typing_indicator_design

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3202.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3202.apk is available for download

@saleniuk saleniuk requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and vitorhugods and removed request for a team July 19, 2024 07:59
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3202.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3202.apk is available for download

alexandreferris
alexandreferris approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh they looking amazing now 🔥

yamilmedina
yamilmedina reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing, a dimension that slipped, great work as always 👏

ohassine
ohassine approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@ohassine ohassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! and thanks for the previews 🚀

@saleniuk saleniuk enabled auto-merge (squash) July 19, 2024 09:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saleniuk saleniuk merged commit 3e62b74 into release/candidate Jul 19, 2024
11 of 12 checks passed
@saleniuk saleniuk deleted the fix/call_participants_tiles_ui-rc branch July 19, 2024 10:16
github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@saleniuk @MohamadJaara @github-actions
fix: call participants tiles UI [WPB-10149] (#3202)
d8cf93d 
Co-authored-by: MohamadJaara <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3202.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3202.apk is available for download

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@ohassine ohassine ohassine approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saleniuk @yamilmedina @alexandreferris @ohassine @MohamadJaara