chore: update compose libs to get rid of rendering crashes [WPB-9666] #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleniuk
commented
Jul 2, 2024
| @@ -182,7 +182,7 @@ class WireActivity : AppCompatActivity() { | |||
| } | |||
| } | |||
|
|
|||
| override fun onNewIntent(intent: Intent?) { | |||
| override fun onNewIntent(intent: Intent) { | |||
There was a problem hiding this comment.
In newest version, ComponentActivity got refactored to kotlin so intent is not nullable anymore
|
|
Built wire-android-staging-compat-pr-3148.apk is available for download |
|
Built wire-android-dev-debug-pr-3148.apk is available for download |
MohamadJaara
approved these changes
Jul 2, 2024
Garzas
approved these changes
Jul 3, 2024
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
With compose v1.7 they introduced some issues related to rendering images which can crash when launching the app.
Solutions
Update compose libraries, in
beta03they introduced exact fix for crashes our app experience:In
beta04they additionally fixed some other issues so we could also benefit from it:Also updated other compose-related libs to newest versions.
Let's hope stable v1.7 comes soon!
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.