Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow parallel merge queue builds [WPB-9914] #3140

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Jun 27, 2024

TaskWPB-9914 Merge Queues - Use them to their fullest


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Current concurrency strategy doesn't allow multiple builds in parallel for the merge queue.

Causes

When running the merge queue, the github.event.pull_request is empty. So it means that builds from multiple PRs will have the same concurrency group.

Solutions

If the PR number is null, use the merge_group.head_sha.

Testing

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, typfel, yamilmedina, alexandreferris, mchenani and ohassine and removed request for a team June 27, 2024 19:26
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link
Contributor

Built wire-android-staging-release-pr-3140.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3140.apk is available for download

@vitorhugods vitorhugods added this pull request to the merge queue Jun 28, 2024
Merged via the queue into develop with commit 8dff1af Jun 28, 2024
10 checks passed
@vitorhugods vitorhugods deleted the ci/allow-parallel-merge-queue-builds branch June 28, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants