-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: audio converting time [WPB-9705] #3127
Conversation
@Garzas looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
@Garzas looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Quality Gate passedIssues Measures |
Built wire-android-staging-release-pr-3127.apk is available for download |
Built wire-android-dev-debug-pr-3127.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wav will be bigger in size than m4a, maybe it's not as big as to become a problem, but maybe we could think of compressing it not when recording or right after, but when sending - it won't be as problematic to the user as now. Also, maybe applying effect takes longer for wav than for m4a because of bigger file size, but I have no idea, just would be good to verify it. 😄
Anyway, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work done here 👏🏻
Generation of the file with effects is now super fast as compared to before 🏃🏻♂️
Tested on Android + iOS + Mac wrapper and everything is as it should be, awesome!
The previous issue with |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Converting audio file to m4a takes too long
Causes (Optional)
Bad user experience waiting for audio to be encoded
Solutions
How to Test
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)