fix: Re-fetching of devices certificates on comming back from DeviceDetails [WPB-6970] #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
MohamadJaara,
vitorhugods,
mchenani,
Garzas and
saleniuk
Test Results825 tests 825 ✅ 9m 10s ⏱️ Results for commit cce7f98. ♻️ This comment has been updated with latest results. |
|
Build 5315 failed. |
|
Build 5316 failed. |
mchenani
approved these changes
Jun 17, 2024
yamilmedina
approved these changes
Jun 17, 2024
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
borichellow
deleted the
fix/re-fetching-of-devices-certificates-on-comming-back-from-device-details
branch
This was referenced Jun 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When user generate the E2EI certificate in DeviceDetails screen and go back to SelfDevices screen, then current device is still displayed as not-verified.
Causes (Optional)
DevicesCertificates list is not observable, but can be just get (CC doesn't provide any option to observe it).
Solutions
Observe
LifecycleEventof SelfDevicesScreen (addedrememberLifecycleEvent()which can be used inLaunchedEffect) and refresh E2EI Certificates on everyResume