Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upload the app to Play Store (WPB-8729) #3058

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented May 31, 2024

TaskWPB-8729 [Android] Setup pipeline step to upload app to beta and prod tracks


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

A Github action used here to upload the apk to Play Store based on build type.

Beta build: we upload the aab to internal
Prod build: we upload the aap to prod track with visibility of 10%
RC build: we upload it to alpha track

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title ci: upload the app to Play Store ci: upload the app to Play Store (WPB-8729) May 31, 2024
@ohassine ohassine requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team May 31, 2024 08:15
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just thinking out loud if we really need the green app.

.github/workflows/build-rc-app.yml Outdated Show resolved Hide resolved
@AndroidBob
Copy link
Collaborator

Build 5094 succeeded.

The build produced the following APK's:

.github/workflows/build-prod-app.yml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@AndroidBob
Copy link
Collaborator

Build 5122 succeeded.

The build produced the following APK's:

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ good to have this one step closer to finish the migration

@ohassine ohassine added this pull request to the merge queue Jun 6, 2024
Merged via the queue into develop with commit 9b16675 Jun 6, 2024
11 checks passed
@ohassine ohassine deleted the upload-app-to-play-store branch June 6, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants