Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: file access crashes [WPB-7368] 🍒 #2995

Merged
merged 2 commits into from
May 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 10, 2024

BugWPB-7368 [Android] Playstore crash - Resample Image and File handling

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added information about about available space and total device space to datadog
  • added snackbar message when access to file on avatar upload fails
  • added more logs when resampling images
  • code cleanup

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/S labels May 10, 2024
@AndroidBob
Copy link
Collaborator

Build 4704 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina requested review from yamilmedina, a team, borichellow, mchenani, Garzas and saleniuk and removed request for a team May 13, 2024 08:51
@Garzas Garzas enabled auto-merge May 14, 2024 10:23
@Garzas Garzas added this pull request to the merge queue May 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 19.35484% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 44.07%. Comparing base (08879d3) to head (d5d0a84).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2995      +/-   ##
===========================================
- Coverage    44.31%   44.07%   -0.25%     
===========================================
  Files          444      445       +1     
  Lines        14492    14524      +32     
  Branches      2493     2497       +4     
===========================================
- Hits          6422     6401      -21     
- Misses        7369     7429      +60     
+ Partials       701      694       -7     
Files Coverage Δ
.../userprofile/avatarpicker/AvatarPickerViewModel.kt 82.35% <66.66%> (-4.95%) ⬇️
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 6.48% <0.00%> (-0.73%) ⬇️
...rc/main/kotlin/com/wire/android/util/DeviceUtil.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08879d3...d5d0a84. Read the comment docs.

Copy link
Contributor Author

Test Results

928 tests  ±0   928 ✅ ±0   9m 21s ⏱️ -31s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit d5d0a84. ± Comparison against base commit 08879d3.

Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit ba3e728 May 14, 2024
10 of 11 checks passed
@Garzas Garzas deleted the chore/file-access-crashes-cherry-pick branch May 14, 2024 11:13
@AndroidBob
Copy link
Collaborator

Build 4730 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants