Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grouping message dates (WPB-1733) 🍒 #2972

Merged
merged 2 commits into from
May 6, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 6, 2024

StoryWPB-1733 Timestamps – grouping functionality for dates

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Previous implementation of grouping message dates had a different design than expected

Solutions

  • Rework with new design
  • Create a better sealed class for message date groups

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Open App
  • Open Any conversation with messages from:
    - Now (just send/receive a message)
    - Within 30 Minutes (let a sent/received message pass at least 1min)
    - Today (30 min < message < Yesterday)
    - Yesterday (Before Yesterday < message < Today)
    - Within Week (7 days ago < message < Yesterday)
    - Not Within Week but Same Year (01.01.this_year < message < 7 days ago)
    - Other (any message that is not from this year)

Attachments (Optional)

Light Mode Dark Mode
light_mode dark_mode

References

https://developer.android.com/reference/android/icu/text/RelativeDateTimeFormatter
https://android.googlesource.com/platform/prebuilts/fullsdk/sources/android-31/+/refs/heads/androidx-core-core-google-shortcuts-release/android/text/format/RelativeDateTimeFormatter.java
https://developer.android.com/reference/android/text/format/DateUtils

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/M labels May 6, 2024
@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and mchenani and removed request for a team May 6, 2024 10:24
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 44.19%. Comparing base (3ed5453) to head (b92afb0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2972   +/-   ##
========================================
  Coverage    44.18%   44.19%           
========================================
  Files          444      444           
  Lines        14472    14479    +7     
  Branches      2486     2490    +4     
========================================
+ Hits          6395     6399    +4     
- Misses        7384     7387    +3     
  Partials       693      693           
Files Coverage Δ
.../conversations/messages/item/RegularMessageItem.kt 0.00% <ø> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 51.61% <50.00%> (-0.16%) ⬇️
.../main/kotlin/com/wire/android/util/DateTimeUtil.kt 75.23% <88.57%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed5453...b92afb0. Read the comment docs.

Copy link
Contributor Author

github-actions bot commented May 6, 2024

Test Results

926 tests   - 1   926 ✅  - 1   12m 42s ⏱️ + 2m 35s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit b92afb0. ± Comparison against base commit 3ed5453.

This pull request removes 1 test.
com.wire.android.mapper.MessageMapperTest ‑ givenMessageWithDate_whenCheckingFormattedUIDates_thenReturnCorrectMessageDateTime()

Copy link
Contributor Author

github-actions bot commented May 6, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris added this pull request to the merge queue May 6, 2024
@AndroidBob
Copy link
Collaborator

Build 4617 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit b5e662e May 6, 2024
12 checks passed
@alexandreferris alexandreferris deleted the feat/grouping_message_dates-cherry-pick branch May 6, 2024 12:25
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants