-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grouping message dates (WPB-1733) 🍒 #2972
feat: grouping message dates (WPB-1733) 🍒 #2972
Conversation
Signed-off-by: alexandreferris <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2972 +/- ##
========================================
Coverage 44.18% 44.19%
========================================
Files 444 444
Lines 14472 14479 +7
Branches 2486 2490 +4
========================================
+ Hits 6395 6399 +4
- Misses 7384 7387 +3
Partials 693 693
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Test Results926 tests - 1 926 ✅ - 1 12m 42s ⏱️ + 2m 35s Results for commit b92afb0. ± Comparison against base commit 3ed5453. This pull request removes 1 test.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4617 succeeded. The build produced the following APK's: |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Previous implementation of grouping message dates had a different design than expected
Solutions
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
- Now (just send/receive a message)
- Within 30 Minutes (let a sent/received message pass at least 1min)
- Today (30 min < message < Yesterday)
- Yesterday (Before Yesterday < message < Today)
- Within Week (7 days ago < message < Yesterday)
- Not Within Week but Same Year (01.01.this_year < message < 7 days ago)
- Other (any message that is not from this year)
Attachments (Optional)
References
https://developer.android.com/reference/android/icu/text/RelativeDateTimeFormatter
https://android.googlesource.com/platform/prebuilts/fullsdk/sources/android-31/+/refs/heads/androidx-core-core-google-shortcuts-release/android/text/format/RelativeDateTimeFormatter.java
https://developer.android.com/reference/android/text/format/DateUtils