-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sketch): draw and send sketchs messages #2905
Conversation
Signed-off-by: yamilmedina <[email protected]>
Signed-off-by: yamilmedina <[email protected]>
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2905 +/- ##
===========================================
+ Coverage 43.77% 43.82% +0.05%
===========================================
Files 435 438 +3
Lines 14258 14334 +76
Branches 2476 2483 +7
===========================================
+ Hits 6241 6282 +41
- Misses 7323 7359 +36
+ Partials 694 693 -1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Test Results898 tests +8 898 ✅ +8 8m 40s ⏱️ - 9m 11s Results for commit eb23e62. ± Comparison against base commit 25ec09e. This pull request removes 1 and adds 9 tests. Note that renamed tests count towards both.
|
APKs built during tests are available here. Scroll down to Artifacts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Build 4267 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glorious 🧑🍳🤌🏻
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Drawing sketches designs applied to poc and main actions, undo, send, color picker.
Solutions
This is a compilation of small PRs
Testing
Test Coverage (Optional)
Attachments (Optional)
Screen.Recording.2024-04-17.at.10.23.37.mp4
Screen_Recording_20240415_182208_Wire.Dev.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.