fix: Remove NotificationDot for some notifications RC #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-some-notifications-rc
Test Results816 tests 816 ✅ 7m 19s ⏱️ Results for commit 7fb5a78. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3969 failed. |
MohamadJaara
approved these changes
Apr 4, 2024
alexandreferris
approved these changes
Apr 4, 2024
…-some-notifications-rc
…-some-notifications-rc
|
APKs built during tests are available here. Scroll down to Artifacts! |
MohamadJaara
deleted the
fix/remove-notification-dot-for-some-notifications-rc
branch
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3986 succeeded. The build produced the following APK's: |
MohamadJaara
added a commit
that referenced
this pull request
Jul 8, 2024
MohamadJaara
added a commit
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
NotificationDot (on app icon) shouldn't be shown for the notifications: OngoingCall, PersistentWebSocket, MigrationWorker, NotificationFetchWorker, SingleUserMigrationWorker
Causes (Optional)
flag
ShowBadgewasn't set to false for those notifications.Solutions
set
ShowBadgeflag tofalsefor the channels of those notifications.