chore: extract send message to viemodel #2824

Garzas · 2024-03-26T14:28:47Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Extracted send message functionality to separate view model to have it in future reusable

pull-request-size · 2024-03-26T14:28:54Z

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

github-actions · 2024-03-26T14:32:18Z

Test Results

878 tests +2 878 ✅ +2 14m 8s ⏱️ +47s
120 suites +2 0 💤 ±0
120 files +2 0 ❌ ±0

Results for commit 94cb684. ± Comparison against base commit de629ad.

This pull request removes 24 and adds 26 tests. Note that renamed tests count towards both.

com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given a user picks an image asset larger than 15MB, when invoked, then sendAssetMessageUseCase isn't called()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given a valid observed enforced self-deleting message timer, when invoked, then the timer gets successfully updated()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given attachment picked and null when getting asset bundle from uri, then show message to user()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that a free user picks an asset larger than 25MB, when invoked, then sendAssetMessageUseCase isn't called()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that a team user sends an asset message larger than 25MB, when invoked, then sendAssetMessageUseCase is called()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that a user picks too large asset that needs saving if invalid, when invoked, then saveToExternalMediaStorage is called()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that a user sends an ping message, when invoked, then sendKnockUseCase and pingRinger are called()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that a user updates the self-deleting message timer, when invoked, then the timer gets successfully updated()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that user chose to dismiss when enabled legal hold before sending, then message is not sent and dialog hidden()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that user chose to dismiss when enabled legal hold when sending fails, then message is not resent and dialog hidden()
…

com.wire.android.ui.home.conversations.composer.MessageComposerViewModelTest ‑ given a valid observed enforced self-deleting message timer, when invoked, then the timer gets successfully updated()
com.wire.android.ui.home.conversations.composer.MessageComposerViewModelTest ‑ given that a user updates the self-deleting message timer, when invoked, then the timer gets successfully updated()
com.wire.android.ui.home.conversations.composer.MessageComposerViewModelTest ‑ given that user saves a draft message, then save draft use case is triggered()
com.wire.android.ui.home.conversations.composer.MessageComposerViewModelTest ‑ given that user types a text message, when invoked typing invoked, then send typing event is called()
com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModelTest ‑ given a user picks an too large image asset, when invoked, then sendAssetMessageUseCase isn't called()
com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModelTest ‑ given attachment picked and error when handling asset from uri, then show message to user()
com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModelTest ‑ given that a free user picks an asset larger than 25MB, when invoked, then sendAssetMessageUseCase isn't called()
com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModelTest ‑ given that a user sends an ping message, when invoked, then sendKnockUseCase and pingRinger are called()
com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModelTest ‑ given that user chose to dismiss when enabled legal hold before sending, then message is not sent and dialog hidden()
com.wire.android.ui.home.conversations.sendmessage.SendMessageViewModelTest ‑ given that user chose to dismiss when enabled legal hold when sending fails, then message is not resent and dialog hidden()
…

♻️ This comment has been updated with latest results.

AndroidBob · 2024-03-26T14:43:22Z

Build 3768 failed.

AndroidBob · 2024-03-26T16:08:06Z

Build 3771 failed.

codecov · 2024-03-27T08:00:44Z

Codecov Report

Attention: Patch coverage is 53.75723% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 43.76%. Comparing base (de629ad) to head (94cb684).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2824      +/-   ##
===========================================
+ Coverage    43.63%   43.76%   +0.13%     
===========================================
  Files          419      421       +2     
  Lines        14022    14019       -3     
  Branches      2535     2537       +2     
===========================================
+ Hits          6118     6135      +17     
+ Misses        7186     7164      -22     
- Partials       718      720       +2

Files	Coverage Δ
...rsations/messages/ConversationMessagesViewModel.kt	`64.64% <100.00%> (+0.19%)`	⬆️
...android/ui/home/conversations/model/AssetBundle.kt	`100.00% <100.00%> (ø)`
...ome/conversations/usecase/HandleUriAssetUseCase.kt	`96.96% <96.96%> (ø)`
.../conversations/sendmessage/SendMessageViewModel.kt	`83.76% <78.57%> (ø)`
...c/main/kotlin/com/wire/android/util/FileManager.kt	`7.14% <0.00%> (-4.40%)`	⬇️
.../com/wire/android/ui/sharing/ImportedMediaAsset.kt	`0.00% <0.00%> (ø)`
...conversations/composer/MessageComposerViewModel.kt	`72.72% <72.72%> (ø)`
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt	`0.00% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de629ad...94cb684. Read the comment docs.

github-actions · 2024-03-27T08:07:01Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-27T08:42:10Z

Build 3779 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9255915)(9255915)-staging-compat.apk

alexandreferris · 2024-03-27T09:01:37Z

app/src/main/kotlin/com/wire/android/ui/home/conversations/media/ConversationMediaScreen.kt

@@ -130,8 +131,8 @@ fun ConversationMediaScreen(
    )

    SnackBarMessage(
-        messageComposerViewModel.infoMessage,
-        conversationMessagesViewModel.infoMessage
+        composerMessages = MutableSharedFlow<SnackBarMessage>().asSharedFlow(),


shouldn't we be passing a shared flow variable here correctly so it can be listened to? this just seems like a new MutableSharedFlow but no one is emitting to it? 🤔

It's used in 2 places where in one place it doesn't have second info message. I will try to figure better way to do it 💪

maybe just make this parameter nullable 😄

alexandreferris

Great work! I just have a tiny question 🤔

github-actions · 2024-03-27T13:21:00Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-27T13:54:01Z

Build 3795 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9257818)(9257818)-staging-compat.apk

github-actions · 2024-03-27T15:26:18Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-27T15:50:10Z

Build 3798 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9258504)(9258504)-staging-compat.apk

Garzas added 3 commits March 26, 2024 13:27

chore: move remove message to conv messages view model

b22b6ea

detekt fix

4af6060

extract send message functionality to separate viewmodel

72399fa

Garzas requested review from yamilmedina, alexandreferris, borichellow and saleniuk March 26, 2024 14:28

Garzas self-assigned this Mar 26, 2024

pull-request-size bot added the size/XL label Mar 26, 2024

Base automatically changed from chore/move-delete-message-to-messages-view-model to develop March 26, 2024 15:48

Merge branch 'develop' into chore/extract-send-message-to-viemodel

1dd135d

alexandreferris reviewed Mar 27, 2024

View reviewed changes

Garzas added 2 commits March 27, 2024 13:46

review fixes

bdac706

Merge branch 'develop' into chore/extract-send-message-to-viemodel

23e02bf

Garzas requested a review from alexandreferris March 27, 2024 12:50

saleniuk approved these changes Mar 27, 2024

View reviewed changes

alexandreferris approved these changes Mar 27, 2024

View reviewed changes

yamilmedina approved these changes Mar 27, 2024

View reviewed changes

chore: handle uri asset (#2827)

94cb684

Garzas enabled auto-merge March 27, 2024 14:56

Garzas added this pull request to the merge queue Mar 27, 2024

Merged via the queue into develop with commit fec0ad9 Mar 27, 2024
13 of 14 checks passed

Garzas deleted the chore/extract-send-message-to-viemodel branch March 27, 2024 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: extract send message to viemodel #2824

chore: extract send message to viemodel #2824

Garzas commented Mar 26, 2024

pull-request-size bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024 •

edited

Loading

AndroidBob commented Mar 26, 2024

AndroidBob commented Mar 26, 2024

codecov bot commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024

AndroidBob commented Mar 27, 2024

alexandreferris Mar 27, 2024

Garzas Mar 27, 2024

saleniuk Mar 27, 2024

alexandreferris left a comment

github-actions bot commented Mar 27, 2024

AndroidBob commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

AndroidBob commented Mar 27, 2024

chore: extract send message to viemodel #2824

chore: extract send message to viemodel #2824

Conversation

Garzas commented Mar 26, 2024

PR Submission Checklist for internal contributors

What's new in this PR?

pull-request-size bot commented Mar 26, 2024

Ups 🫰🟨

github-actions bot commented Mar 26, 2024 • edited Loading

Test Results

AndroidBob commented Mar 26, 2024

AndroidBob commented Mar 26, 2024

codecov bot commented Mar 27, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 27, 2024

AndroidBob commented Mar 27, 2024

alexandreferris Mar 27, 2024

Choose a reason for hiding this comment

Garzas Mar 27, 2024

Choose a reason for hiding this comment

saleniuk Mar 27, 2024

Choose a reason for hiding this comment

alexandreferris left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 27, 2024

AndroidBob commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

AndroidBob commented Mar 27, 2024

github-actions bot commented Mar 26, 2024 •

edited

Loading

codecov bot commented Mar 27, 2024 •

edited

Loading