-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add structured logs to location and fix permission handling (WPB-6358) #2736
Conversation
Build 3308 failed. |
@@ -69,7 +69,7 @@ android { | |||
// For all other flavors use the "nonfree" sourceSets | |||
} else { | |||
getByName("main") { | |||
java.srcDirs("src/nonfree/kotlin") | |||
java.srcDirs("src/main/kotlin", "src/nonfree/kotlin") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix, otherwise we don't have autocompletion at all for classes coming from this nonfree
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2736 +/- ##
========================================
Coverage 43.12% 43.12%
========================================
Files 408 408
Lines 13522 13544 +22
Branches 2390 2392 +2
========================================
+ Hits 5831 5841 +10
- Misses 7007 7018 +11
- Partials 684 685 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3309 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/location/LocationPickerHelper.kt
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References