Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): list app flavours #2735

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Feb 23, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

What are build flavours??

Causes

Too many, idk.

Solutions

Explain what they are, what they do, what they think, who's their favourite pop singer, if they care about cappuccino after 11AM or not.

Testing

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, yamilmedina, alexandreferris, MohamadJaara, ohassine and saleniuk and removed request for a team February 23, 2024 11:04
Copy link
Contributor

github-actions bot commented Feb 23, 2024

Test Results

821 tests   821 ✅  9m 25s ⏱️
114 suites    0 💤
114 files      0 ❌

Results for commit 56e9f53.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3296 failed.

@vitorhugods vitorhugods added this pull request to the merge queue Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.07%. Comparing base (0e0430d) to head (56e9f53).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2735      +/-   ##
===========================================
- Coverage    43.08%   43.07%   -0.01%     
===========================================
  Files          408      408              
  Lines        13523    13521       -2     
  Branches      2390     2389       -1     
===========================================
- Hits          5826     5824       -2     
  Misses        7014     7014              
  Partials       683      683              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e30983...56e9f53. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit e31b062 Feb 23, 2024
13 of 14 checks passed
@vitorhugods vitorhugods deleted the docs/add-entry-about-app-flavors branch February 23, 2024 12:43
@AndroidBob
Copy link
Collaborator

Build 3300 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants