Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tag logging #2730

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. We were not properly passing tag to DataDogLogger. So it was harder to find where the logs were coming from.
  2. Kalium was buggy and was never returning the user info to append with the logs.

Solutions

  1. Update Kalium that now has a fix
  2. Pass the tag as a attribute together with wire.userId and wire.clientId (so it doesn't get confused with DataDog's userId)

Dependencies

Needs releases with:

Testing

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, typfel, yamilmedina, borichellow and mchenani and removed request for a team February 22, 2024 16:19
Copy link
Contributor

@vitorhugods looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
5f9f8a854cb91f4241923f04161c30343b2e021f 7a261258aa94b6bf5c8f3c50d1bfa4e4222f6864

Is this intentional?

@vitorhugods
Copy link
Member Author

@vitorhugods looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
release/candidate This PR
5f9f8a854cb91f4241923f04161c30343b2e021f 7a261258aa94b6bf5c8f3c50d1bfa4e4222f6864

Is this intentional?

I'll fix this once Kalium is merged :)

Copy link
Contributor

github-actions bot commented Feb 22, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit db15b4f.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3270 failed.

@AndroidBob
Copy link
Collaborator

Build 3285 failed.

@MohamadJaara MohamadJaara merged commit 63fd841 into release/candidate Feb 23, 2024
7 of 8 checks passed
@MohamadJaara MohamadJaara deleted the chore/fix-tag-logging branch February 23, 2024 10:52
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
@AndroidBob AndroidBob mentioned this pull request Feb 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants