-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix tag logging #2730
chore: fix tag logging #2730
Conversation
@vitorhugods looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
I'll fix this once Kalium is merged :) |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit db15b4f. ♻️ This comment has been updated with latest results. |
Build 3270 failed. |
274a7f8
to
db15b4f
Compare
Build 3285 failed. |
Co-authored-by: MohamadJaara <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
tag
to DataDogLogger. So it was harder to find where the logs were coming from.Solutions
tag
as aattribute
together withwire.userId
andwire.clientId
(so it doesn't get confused with DataDog's userId)Dependencies
Needs releases with:
Testing
N/A
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.