Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove jacoco and migrate to kover (ACOL-139) #2671

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Feb 7, 2024

TopicACOL-139 Min. code coverage thresholds

Cherry pick of :



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Follow up of #2662 to improve test coverage

Solutions

  • Removes jacoco config.
  • Use kover for better coverage support and filtering of classes and annotations.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Feb 7, 2024
@yamilmedina yamilmedina added the cherry-pick PR is cherry-picking changes from another banch label Feb 7, 2024
@yamilmedina yamilmedina requested review from alexandreferris, MohamadJaara, vitorhugods, Garzas, a team and typfel and removed request for a team February 7, 2024 14:49
uses: codecov/codecov-action@v4
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (b629f32) 41.82% compared to head (491aa9c) 42.77%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2671      +/-   ##
=============================================
+ Coverage      41.82%   42.77%   +0.95%     
=============================================
  Files            367      404      +37     
  Lines          13327    13440     +113     
  Branches        1769     2373     +604     
=============================================
+ Hits            5574     5749     +175     
+ Misses          7213     7012     -201     
- Partials         540      679     +139     
Files Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...entication/devices/register/RegisterDeviceState.kt 100.00% <100.00%> (ø)
...ui/home/conversations/search/SearchPeopleRouter.kt 0.00% <ø> (ø)
...ch/messages/SearchConversationMessagesViewModel.kt 86.48% <100.00%> (+7.53%) ⬆️
...ld/dialog/requested/LegalHoldRequestedViewModel.kt 90.00% <ø> (+3.48%) ⬆️
...erprofile/other/OtherUserProfileScreenViewModel.kt 58.82% <100.00%> (ø)
...roid/ui/userprofile/other/OtherUserProfileState.kt 77.27% <100.00%> (+1.71%) ⬆️
...ndroid/ui/userprofile/self/SelfUserProfileState.kt 100.00% <100.00%> (+100.00%) ⬆️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 52.55% <100.00%> (+52.55%) ⬆️
.../android/feature/e2ei/GetE2EICertificateUseCase.kt 0.00% <0.00%> (ø)
... and 17 more

... and 360 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5803646...491aa9c. Read the comment docs.

@yamilmedina yamilmedina added this pull request to the merge queue Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Test Results

812 tests  ±0   812 ✅ ±0   15m 27s ⏱️ - 4m 24s
112 suites ±0     0 💤 ±0 
112 files   ±0     0 ❌ ±0 

Results for commit 491aa9c. ± Comparison against base commit 5803646.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2951 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina self-assigned this Feb 7, 2024
Merged via the queue into develop with commit 9625981 Feb 7, 2024
15 checks passed
@yamilmedina yamilmedina deleted the chore/test-migrate-to-kover-cherrypick branch February 7, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants