-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: legal hold indication on user profiles [WPB-4780] #2658
Conversation
Build 2861 failed. |
Build 2862 failed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2658 +/- ##
=============================================
+ Coverage 41.82% 42.50% +0.68%
- Complexity 1158 1171 +13
=============================================
Files 367 367
Lines 13327 13346 +19
Branches 1769 1773 +4
=============================================
+ Hits 5574 5673 +99
+ Misses 7213 7123 -90
- Partials 540 550 +10
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2863 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! I just have a tiny comment on a hardcoded dimension
app/src/main/kotlin/com/wire/android/ui/legalhold/banner/LegalHoldBaseBanner.kt
Outdated
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2870 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
As a user I want to see an indication on user profiles that are under legal hold so that I’m more aware of my privacy.
Solutions
Change the legal hold banner to distinguish between "legal hold active" and "legal hold request pending".
Add legal hold banner to self user profile in both cases and to other user profile when active.
Show proper dialogs when clicking on legal hold banner.
Testing
Test Coverage (Optional)
How to Test
Request legal hold for the current user or enable it for other user and open the self or other user profile to see the banner.
Attachments (Optional)
Screen_recording_20240202_164654.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.