Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show a dialog when current client's certificate is revoked (WPB-6145) #2594

Merged
merged 8 commits into from
Jan 26, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 18, 2024

TaskWPB-6145 [Android] Show Your Device's Cert Revoked


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Once we discover that the certificate of current client is revoked we need to display we dialog that recommends to the user to logout and login again to get a new certificate

Dependencies (Optional)

Needs wireapp/kalium#2384

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Screen_recording_20240118_105707.webm

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Test Results

753 tests  +1   753 ✅ +1   7m 23s ⏱️ - 5m 2s
106 suites ±0     0 💤 ±0 
106 files   ±0     0 ❌ ±0 

Results for commit c92195b. ± Comparison against base commit 936df80.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2639 failed.

@AndroidBob
Copy link
Collaborator

Build 2640 failed.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (936df80) 41.46% compared to head (c92195b) 41.41%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2594      +/-   ##
=============================================
- Coverage      41.46%   41.41%   -0.06%     
- Complexity      1151     1154       +3     
=============================================
  Files            368      368              
  Lines          13283    13322      +39     
  Branches        1749     1754       +5     
=============================================
+ Hits            5508     5517       +9     
- Misses          7248     7277      +29     
- Partials         527      528       +1     
Files Coverage Δ
...otlin/com/wire/android/ui/home/FeatureFlagState.kt 92.85% <100.00%> (+0.26%) ⬆️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 56.56% <70.00%> (+0.95%) ⬆️
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 68.47% <0.00%> (-3.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936df80...c92195b. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2642 succeeded.

The build produced the following APK's:

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, MohamadJaara, vitorhugods and mchenani and removed request for a team January 23, 2024 08:40
Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndroidBob
Copy link
Collaborator

Build 2748 failed.

@ohassine ohassine added this pull request to the merge queue Jan 26, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@ohassine ohassine added this pull request to the merge queue Jan 26, 2024
@AndroidBob
Copy link
Collaborator

Build 2761 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 43695b0 Jan 26, 2024
13 of 14 checks passed
@ohassine ohassine deleted the show_your_device_cert_revoked_dialog branch January 26, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants