-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show a dialog when current client's certificate is revoked (WPB-6145) #2594
Conversation
Build 2639 failed. |
Build 2640 failed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2594 +/- ##
=============================================
- Coverage 41.46% 41.41% -0.06%
- Complexity 1151 1154 +3
=============================================
Files 368 368
Lines 13283 13322 +39
Branches 1749 1754 +5
=============================================
+ Hits 5508 5517 +9
- Misses 7248 7277 +29
- Partials 527 528 +1
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2642 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build 2748 failed. |
…ert_revoked_dialog # Conflicts: # kalium
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2761 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Description
Once we discover that the certificate of current client is revoked we need to display we dialog that recommends to the user to logout and login again to get a new certificate
Dependencies (Optional)
Needs wireapp/kalium#2384
Needs releases with:
Testing
Test Coverage (Optional)
Attachments (Optional)
Screen_recording_20240118_105707.webm
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.