Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github-action ci step to v1 #22

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

spoonman01
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Outdated CI step for Google is blocking any new deploy

Solutions

Update outdated CI step for Google to v1

Testing

How to Test

QA can test with other existing integrations using Poll bot in staging env for e2e tests

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Copy link

@ap-ext-wire ap-ext-wire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me and it set up according to this docs https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke
setting USE_GKE_GCLOUD_AUTH_PLUGIN=True means, that also for old k8s version the new auth library should be used.

Copy link

@jschumacher-wire jschumacher-wire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spoonman01 spoonman01 merged commit 6e2d820 into staging Sep 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants